Releases showing 90 commits with custom Bitbucket integration

SeBsZ · August 6, 2019, 11:32am

Hello,

I connected Sentry to Bitbucket so that it has access to commits and such. Following the guide at https://docs.sentry.io/workflow/releases/?platform=php I realized I also needed to notify Sentry of certain events so that it can create and deploy releases. So, I wrote my own webhook script, and added that webhook to Bitbucket. Now Bitbucket calls my script whenever a PR is created and when a PR is merged. Inside the script I’m talking to the Sentry API to create and deploy releases (https://docs.sentry.io/api/releases/post-organization-releases/).

All of this is working, but the issue is associating the correct commits. It seems Sentry always associates the maximum of 90 commits. I have not specified a previousCommit, because this information is not inside Bitbucket’s webhook. This is also the reason why I can’t specify all the individual commits in the PR as again, this information is not inside the webhook body. It only supplies the head commit and some other data.

Here’s a screenshot showing all the releases with 90 commits:

My question is twofold:

Why isn’t the automatic previousCommit detection working? The docs specify that specifying a previousCommit is not required, and that Sentry will automatically determine the previous release’s commit. As a follow-up question, I am also wondering if this method will ever work reliably? Our team works on several hotfixes and features simultaneously, and I’m afraid that using this method one release will end up containing commits belonging to other releases?
Since Sentry is already hooked up to my Bitbucket repo, why doesn’t Sentry offer the option of creating and deploying releases when it detects that a Pull Request has been created or merged in Bitbucket? That would avoid the need for me to maintain my own webhook script and also avoids me from needing to build an OAuth authentication flow to gather the commit data from Bitbucket myself.

Perhaps I’m just doing something wrong, please let me know. In any case, thanks a lot for your help!

archon810 · August 9, 2019, 5:47am

Thanks for submitting this, @SeBsZ. I’m going to ping support to help answer this.

marbon87 · June 25, 2020, 5:22am

Hi @SeBsZ, did you find a solution for this?
I have a similar problem, that sentry only loads the first 25 commits from bitbucket (server): https://github.com/getsentry/sentry/issues/19201

marbon87 · June 25, 2020, 6:45am

The problem seems is here:

github.com

getsentry/sentry/blob/b8b6ee2b09fab2cec2db3f0cdf1ed50a8fb17575/src/sentry/integrations/bitbucket/client.py#L151



def compare_commits(self, repo, start_sha, end_sha):
    # where start_sha is oldest and end_sha is most recent
    # see
    # https://developer.atlassian.com/bitbucket/api/2/reference/resource/repositories/%7Busername%7D/%7Brepo_slug%7D/commits/%7Brevision%7D
    commits = []
    done = False

    url = BitbucketAPIPath.repository_commits.format(repo=repo, revision=end_sha)

    while not done and len(commits) < 90:
        data = self.get(url)

        for commit in data["values"]:
            if commit["hash"] == start_sha:
                done = True
                break
            commits.append(commit)

        # move page forward
        try:

The max-limit of 90 commits is hard-coded.

Topic		Replies	Views
Cant set more then 90 commits from Bitbucket	3	862	August 19, 2020
[sentry.io] No commits associated with a release	13	6372	August 2, 2018
[sentry.io] Bitbucket 555 & missing commits Feedback	0	1165	April 7, 2020
Unable to Fetch Commits (Bitbucket) Integrations	2	1178	April 14, 2020
Bitbucket : Only one configuration missing Integrations	2	1687	June 29, 2018

Releases showing 90 commits with custom Bitbucket integration

Related topics