Unsure about Github Enterprise new app configurations

arian · January 17, 2021, 9:01pm

Hi All,

I’m following directions on GitHub | Sentry Documentation for configuring creating a new Github Enterprise - Github app, but the directions are unclear about a few options.

I don’t see any guidance in Sentry docs on enabling/disabling the following options:

Expire user authorization tokens
Request user authorization (OAuth) during installation
Redirect on update

arian · January 19, 2021, 6:38am

I found the on premise guide which gives a bit more information but leaves out the questions I was wondering about above.

BYK · January 19, 2021, 10:05pm

It should be the same with the exception that you need to set this config option to point to your GHE instance (github-login.base-domain):

github.com

getsentry/sentry/blob/2a369fa0c90186f67bfd12a94c980e1b6f0e5643/src/sentry/options/defaults.py#L145


register("github-app.name", default="")
register("github-app.webhook-secret", default="")
register("github-app.private-key", default="")
register("github-app.client-id", flags=FLAG_PRIORITIZE_DISK)
register("github-app.client-secret", flags=FLAG_PRIORITIZE_DISK)
# GitHub Auth
register("github-login.client-id", default="", flags=FLAG_PRIORITIZE_DISK)
register("github-login.client-secret", default="", flags=FLAG_PRIORITIZE_DISK)
register("github-login.reqire-verified-email", type=Bool, default=False, flags=FLAG_PRIORITIZE_DISK)
register("github-login.base-domain", default="github.com", flags=FLAG_PRIORITIZE_DISK)
register("github-login.api-domain", default="api.github.com", flags=FLAG_PRIORITIZE_DISK)
register("github-login.extended-permissions", type=Sequence, default=[], flags=FLAG_PRIORITIZE_DISK)
register("github-login.organization", flags=FLAG_PRIORITIZE_DISK)
# VSTS Integration
register("vsts.client-id", flags=FLAG_PRIORITIZE_DISK)
register("vsts.client-secret", flags=FLAG_PRIORITIZE_DISK)
# VSTS Integration - with limited scopes
register("vsts-limited.client-id", flags=FLAG_PRIORITIZE_DISK)
register("vsts-limited.client-secret", flags=FLAG_PRIORITIZE_DISK)